Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update .gitignore for ignoring goenv .go-version file #2242

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Update .gitignore for ignoring goenv .go-version file #2242

merged 2 commits into from
Dec 27, 2021

Conversation

siansiansu
Copy link
Contributor

Hi reviewers:

I updated the .gitignore to ignore the .go-version file in this PR.
If merged, it's easy to manage different go version locally for the goenv user.
Please help to review it. Thanks!

Reference
https://github.com/syndbg/goenv/blob/master/COMMANDS.md#goenv-local

@siansiansu
Copy link
Contributor Author

I have signed the CLA, please help to re-run it if approved.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @siansiansu !
Let's please make the comment a bit more useful.

.gitignore Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #2242 (87a1844) into master (4d7a0b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2242   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         113      113           
  Lines       10205    10205           
=======================================
  Hits         9981     9981           
  Misses        156      156           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7a0b5...87a1844. Read the comment docs.

@siansiansu siansiansu requested a review from gmlewis December 27, 2021 18:10
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @siansiansu !
LGTM.
Merging.

@gmlewis gmlewis merged commit a899e0f into google:master Dec 27, 2021
@siansiansu siansiansu deleted the update-gitignore branch December 28, 2021 02:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants