Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Repo and Org fields to DeployKeyEvent #2280

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

IainSteers
Copy link
Contributor

Fixes #2279

@IainSteers
Copy link
Contributor Author

Hey @gmlewis this should cover the deploy-key event updates.

I've also expanded the marshal test to include the newer fields

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2280 (e730289) into master (e1c28bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2280   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         114      114           
  Lines       10266    10266           
=======================================
  Hits        10042    10042           
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c28bc...e730289. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IainSteers !
LGTM.
Merging.

@gmlewis gmlewis merged commit 3c43a10 into google:master Feb 3, 2022
@IainSteers IainSteers deleted the issue-2279-deploy-key branch February 3, 2022 17:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DeployKeyEvent to include repo/org objects
2 participants