Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

InstallationPermissions: organization perms #2452

Merged
merged 1 commit into from
Sep 7, 2022
Merged

InstallationPermissions: organization perms #2452

merged 1 commit into from
Sep 7, 2022

Conversation

thepwagner
Copy link
Contributor

@thepwagner thepwagner commented Sep 6, 2022

Adds organization_custom_roles and organization_packages as available permissions on the InstallPermissions struct, per https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app

I've functionally tested the organization_custom_roles bit, but I'm not sure how to verify organization_packages. It is documented online and in other libraries like octokit: https://github.com/search?q=org%3Aoctokit+organization_packages&type=code , but I can't add it to a test github.com app. It may only be available on GitHub Enterprise? 🤷

Add `organization_custom_roles` and `organization_packages` as available
permissions, per https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app

Signed-off-by: Peter Wagner <1559510+thepwagner@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #2452 (663def3) into master (e8cac35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2452   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         122      122           
  Lines       10689    10689           
=======================================
  Hits        10479    10479           
  Misses        144      144           
  Partials       66       66           
Impacted Files Coverage Δ
github/apps.go 95.16% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @thepwagner !
LGTM.
Merging.

@gmlewis gmlewis merged commit 52cc49e into google:master Sep 7, 2022
@thepwagner thepwagner deleted the install-permissions-organization-packages branch September 7, 2022 08:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants