Skip to content

Add SecretScanningPushProtection field to SecurityAndAnalysis struct #2476

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Add SecretScanningPushProtection field to SecurityAndAnalysis struct #2476

merged 2 commits into from
Sep 22, 2022

Conversation

kuhlman-labs
Copy link
Contributor

The Update a repository endpoint in the GitHub API has added an additional field to the security and analysis object to configure secret scanning push protection for a repository. Proposing adding additional fields in SecurityAndAnalysis struct to support configuration with Repositories.Edit
Closes:
#2475

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #2476 (53ca9cd) into master (182338c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2476   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         122      122           
  Lines       10695    10695           
=======================================
  Hits        10485    10485           
  Misses        144      144           
  Partials       66       66           
Impacted Files Coverage Δ
github/repos.go 98.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kuhlman-labs !
One minor tweak, please.

@gmlewis gmlewis changed the title Adding SecretScanningPushProtection field to SecurityAndAnalysis struct closes:#2475 Add SecretScanningPushProtection field to SecurityAndAnalysis struct Sep 22, 2022
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kuhlman-labs !
LGTM.
Merging.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants