-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create custom role APIs #2494
Create custom role APIs #2494
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
5e8c0d0
to
3d4fccb
Compare
3d4fccb
to
e399465
Compare
Hi @mohaldu - please don't use force-push in this repo... we always squash-and-merge anyway, so it is not necessary. See CONTRIBUTING.md for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mohaldu!
Just a few changes, please, then we should be ready for a second review before merging.
Hi @gmlewis thanks for the review, all changes made |
@mohaldu - please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mohaldu !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
==========================================
- Coverage 97.99% 97.97% -0.03%
==========================================
Files 123 123
Lines 10774 10813 +39
==========================================
+ Hits 10558 10594 +36
- Misses 148 150 +2
- Partials 68 69 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohaldu LGTM!
Thank you, @valbeat ! |
resolves #2493