Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add GetTime method to Timestamp #2743

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

6543
Copy link
Contributor

@6543 6543 commented Apr 8, 2023

add a small handy helper func

github/timestamp.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #2743 (8508610) into master (4fec23d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2743   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11611    11616    +5     
=======================================
+ Hits        11385    11390    +5     
  Misses        154      154           
  Partials       72       72           
Impacted Files Coverage Δ
github/timestamp.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @6543 .
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 8, 2023
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 8, 2023
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 9, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 9, 2023

Thank you, @yardenshoham !
Merging.

@gmlewis gmlewis changed the title Add GetTime() to Timestamp Add GetTime method to Timestamp Apr 9, 2023
@gmlewis gmlewis merged commit 521fd0d into google:master Apr 9, 2023
@6543 6543 deleted the timestamp_add_gettime branch April 10, 2023 09:27
sonjek pushed a commit to sonjek/gitea that referenced this pull request May 30, 2023
silverwind added a commit to go-gitea/gitea that referenced this pull request May 31, 2023
based on google/go-github#2743

because of
#23946 (comment)

---------

Co-authored-by: silverwind <me@silverwind.io>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants