Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix missing Include, Exclude fields in RulesetRefConditionParameters #2810

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

danztran
Copy link
Contributor

Fix #2809

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @danztran !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2810 (640ca68) into master (56c2c3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2810   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         136      136           
  Lines       12263    12263           
=======================================
  Hits        12025    12025           
  Misses        162      162           
  Partials       76       76           
Impacted Files Coverage Δ
github/repos_rules.go 100.00% <ø> (ø)

@gmlewis gmlewis changed the title No omit Include, Exclude fields in RulesetRefConditionParameters Fix missing Include, Exclude fields in RulesetRefConditionParameters Jun 19, 2023
@gmlewis gmlewis merged commit 487c80d into google:master Jun 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create Repo Ruleset if RefName fields are empty
2 participants