Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add TriggeringActor to WorkflowRun #2879

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 16, 2023

Fixes: #2874 .

This PR also improves the developer experience by making the output of testJSONMarshal more readable.
This PR also runs "go mod tidy" which appears to be long overdue.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 16, 2023

@Parker77 - do you have time for a review, please?

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2879 (677e79d) into master (2831a6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2879   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         139      139           
  Lines       12357    12357           
=======================================
  Hits        12119    12119           
  Misses        162      162           
  Partials       76       76           
Files Changed Coverage Δ
github/actions_workflow_runs.go 100.00% <ø> (ø)

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 16, 2023
@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 16, 2023

Thank you, @Parker77!
Merging.

@gmlewis gmlewis merged commit b9027bd into google:master Aug 16, 2023
@gmlewis gmlewis deleted the chore/i2874-add-triggering-actor branch August 16, 2023 16:50
gmlewis added a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance WorkflowRun struct with TriggeringActor
2 participants