Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing CodeScanning endpoints #2900

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Add missing CodeScanning endpoints #2900

merged 4 commits into from
Aug 30, 2023

Conversation

jporzucek
Copy link
Contributor

Fixes #2899

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #2900 (81acba8) into master (38ca69f) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
+ Coverage   98.10%   98.11%   +0.01%     
==========================================
  Files         142      142              
  Lines       12340    12415      +75     
==========================================
+ Hits        12106    12181      +75     
  Misses        159      159              
  Partials       75       75              
Files Changed Coverage Δ
github/code-scanning.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek .
Just a few changes to make, please, mostly relating to capitalizations, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
github/code-scanning.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Aug 26, 2023
@jporzucek
Copy link
Contributor Author

jporzucek commented Aug 28, 2023

@ganeshkumarsv @nightlark @AbbanMustafa Since you've been working on this file, kindly ask for an approval 🙏

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Aug 30, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Aug 30, 2023

Thank you, @WillAbides !
Merging.

@gmlewis gmlewis merged commit e3cda78 into google:master Aug 30, 2023
gmlewis pushed a commit to gmlewis/go-github that referenced this pull request Sep 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CodeScanning endpoints
3 participants