Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test for resource JSON marshaling - ActionVariable #2942

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

ResamVi
Copy link
Contributor

@ResamVi ResamVi commented Oct 1, 2023

Hello,

this is just another trivial test adding to the 10 year old issue. I hope there is still demand for this.

Helps #55

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 1, 2023

Thank you, @ResamVi - is this for hacktoberfest credit?
If so, I'll label it as accepted.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 1, 2023

Please make sure unit tests pass locally first by running go test ./....

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #2942 (73ea7e5) into master (d99d3df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2942   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         145      145           
  Lines       12720    12720           
=======================================
  Hits        12490    12490           
  Misses        156      156           
  Partials       74       74           

@ResamVi
Copy link
Contributor Author

ResamVi commented Oct 1, 2023

Whoops, that was a tad too hasty of me 🙈 . Should be fixed now.

This is indeed for hacktoberfest so I would happily take the accept label :). Thanks for your time!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ResamVi !
LGTM.
Merging.

@gmlewis gmlewis changed the title Add tests for resource JSON marshaling - ActionVariable Add test for resource JSON marshaling - ActionVariable Oct 1, 2023
@gmlewis gmlewis merged commit 25309f3 into google:master Oct 1, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants