-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for deployment protection rules #3050
Add support for deployment protection rules #3050
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3050 +/- ##
==========================================
- Coverage 97.71% 97.70% -0.02%
==========================================
Files 152 153 +1
Lines 13241 13310 +69
==========================================
+ Hits 12939 13005 +66
- Misses 213 215 +2
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @abhishekbiyala !
Just a few minor tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @abhishekbiyala !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Hi, @abhishekbiyala |
Thank you, @fchimpan ! |
Fixes #3022