Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test case for JSON resource marshaling #3075

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add test case for JSON resource marshaling #3075

merged 1 commit into from
Feb 14, 2024

Conversation

ShervilG
Copy link
Contributor

Hi All,

Just came across this repository and wanted to start contributing, this is for #55
Hope this is still required ?

@gmlewis gmlewis changed the title Added json marshaling test - SecretScanningAlertUpdateOptions Add test case for JSON resource marshaling Feb 14, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 14, 2024

Yes, thanks.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b8c7fa) 97.72% compared to head (111ee3f) 92.86%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
- Coverage   97.72%   92.86%   -4.86%     
==========================================
  Files         153      170      +17     
  Lines       13390    11400    -1990     
==========================================
- Hits        13085    10587    -2498     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ShervilG.
LGTM.
Merging.

@gmlewis gmlewis merged commit 8bb3d09 into google:master Feb 14, 2024
6 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants