Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Refactor org_custom_roles.go into multiple files #3291

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Sep 24, 2024

Continuation of #3281 (comment)

The /organizations/ORGANIZATION_ID/custom_roles endpoint has been deprecated in favor of /orgs/ORG/custom-repository-roles. So the orgs_custom_roles.go file should be refactored. The file also deals with Organization roles, which is a separate kind of resource to the Organization Repository Roles. For this reason this PR aims to separate the file into two:

  • orgs_custom_repository_roles.go - API docs - /orgs/ORG/custom-repository-roles
  • orgs_organization_roles.go - API docs - /orgs/ORG/organization-roles

@felixlut felixlut marked this pull request as ready for review September 24, 2024 16:28
@gmlewis gmlewis changed the title chore: refactor org_custom_roles.go strucutre into multiple files chore: Refactor org_custom_roles.go into multiple files Sep 25, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
Any time a new file is created, we bump the copyright year to the current year, but if a file is renamed or otherwise edited, we leave the copyright year alone...
So just a couple minor nits, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/orgs_custom_repository_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_repository_roles_test.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (2b8c7fa) to head (d590920).
Report is 127 commits behind head on master.

Files with missing lines Patch % Lines
github/orgs_custom_repository_roles.go 95.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
- Coverage   97.72%   92.97%   -4.75%     
==========================================
  Files         153      172      +19     
  Lines       13390    11715    -1675     
==========================================
- Hits        13085    10892    -2193     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@felixlut felixlut changed the title chore: Refactor org_custom_roles.go into multiple files refactor: Refactor org_custom_roles.go into multiple files Sep 26, 2024
Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 1, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 1, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit cd59fac into google:master Oct 1, 2024
5 of 7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants