Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add CreatedAt and UpdatedAt to Ruleset #3316

Merged

Conversation

ivanmartos
Copy link
Contributor

This PR will expose fields CreatedAt and UpdatedAt for Ruleset

Closes #3315

Copy link

google-cla bot commented Oct 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title feat: export createdAt and updatedAt for ruleset feat: Add CreatedAt and UpdatedAt to Ruleset Oct 8, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ivanmartos !
Please run go generate ./... and push (not force-push) the changes to this PR as explained in step 4 of CONTRIBUTING.md.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (8f11111).
Report is 143 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
- Coverage   97.72%   93.05%   -4.67%     
==========================================
  Files         153      172      +19     
  Lines       13390    11760    -1630     
==========================================
- Hits        13085    10943    -2142     
- Misses        215      723     +508     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivanmartos ivanmartos requested a review from gmlewis October 8, 2024 12:53
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ivanmartos !
LGTM.
Merging.

@gmlewis gmlewis merged commit 13afa20 into google:master Oct 8, 2024
6 of 7 checks passed
@ivanmartos ivanmartos deleted the feat/exposeCreatedAtUpdatedAtRuleset branch October 22, 2024 13:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: expose CreatedAt and UpdatedAt from ruleset
2 participants