-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add CreatedAt and UpdatedAt to Ruleset #3316
feat: Add CreatedAt and UpdatedAt to Ruleset #3316
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ivanmartos !
Please run go generate ./...
and push (not force-push) the changes to this PR as explained in step 4 of CONTRIBUTING.md.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
==========================================
- Coverage 97.72% 93.05% -4.67%
==========================================
Files 153 172 +19
Lines 13390 11760 -1630
==========================================
- Hits 13085 10943 -2142
- Misses 215 723 +508
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ivanmartos !
LGTM.
Merging.
This PR will expose fields
CreatedAt
andUpdatedAt
forRuleset
Closes #3315