Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade jdk used by release action to 21 #1015

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

EvaristeGalois11
Copy link
Contributor

@EvaristeGalois11 EvaristeGalois11 commented Dec 19, 2023

Hi, I'm trying to use the newly released version 1.19.0 from the command-line, but it gives me the following error:

error: com.google.googlejavaformat.java.java21.Java21InputAstVisitor
java.lang.LinkageError: com.google.googlejavaformat.java.java21.Java21InputAstVisitor
        at com.google.googlejavaformat.java.Formatter.createVisitor(Formatter.java:182)
        at com.google.googlejavaformat.java.Formatter.format(Formatter.java:156)
        at com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:283)
        at com.google.googlejavaformat.java.Formatter.formatSource(Formatter.java:257)
        at com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:75)
        at com.google.googlejavaformat.java.FormatFileCallable.call(FormatFileCallable.java:29)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.ClassNotFoundException: com.google.googlejavaformat.java.java21.Java21InputAstVisitor
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:421)
        at java.base/java.lang.Class.forName(Class.java:412)
        at com.google.googlejavaformat.java.Formatter.createVisitor(Formatter.java:177)
        ... 11 more

After doing some tests I think the problem is that the release action is using a jdk 17. This does activate the maven profile jdk17 introduced in this PR #988 and so java 21 specific classes aren't included in the build process. This simple upgrade should fix the problem.

@cushon cushon merged commit 0e7cc6f into google:master Dec 19, 2023
8 checks passed
@EvaristeGalois11 EvaristeGalois11 deleted the upgrade-release-jdk branch December 20, 2023 02:04
cushon added a commit that referenced this pull request Oct 4, 2024
also use 21 for snapshot builds, see #1015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants