Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix JsonWriter documentation regarding top-level value #1766

Conversation

Marcono1234
Copy link
Collaborator

RFC 7159 allows any top-level value (not only arrays or objects) [0], however when #773 added this functionality it appears the author forgot to update the documentation of these classes.

[0] https://tools.ietf.org/html/rfc7159#appendix-A

Changed the definition of "JSON text" so that it can be any JSON value, removing the constraint that it be an object or array.

RFC 7159 allows any top-level value (not only arrays or objects) [0],
however when google#773 added this functionality it appears the author forgot
to update the documentation of these classes.

[0] https://tools.ietf.org/html/rfc7159#appendix-A
> Changed the definition of "JSON text" so that it can be any JSON
> value, removing the constraint that it be an object or array.
@google-cla google-cla bot added the cla: yes label Aug 25, 2020
@Marcono1234
Copy link
Collaborator Author

@eamonnmcmanus, can you please have a look?

@Marcono1234 Marcono1234 changed the title Fix JsonReader / JsonWriter documentation regarding top-level value Fix JsonWriter documentation regarding top-level value Aug 7, 2022
@eamonnmcmanus eamonnmcmanus merged commit f7cefcb into google:master Aug 7, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/fix-javadoc-any-top-level-value-allowed branch August 7, 2022 23:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants