Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the final keyword from private method #2276

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Remove the final keyword from private method #2276

merged 1 commit into from
Dec 9, 2022

Conversation

MaicolAntali
Copy link
Contributor

Remove the final keyword from private method. private methods are implicitly final

@eamonnmcmanus
Copy link
Member

Ah yes, that other method in #2275 is @SafeVarargs and in the older Java versions we build with such a method must be either static or final. :-( Looks like Java 9 also allows private but we build with Java 8.

@eamonnmcmanus eamonnmcmanus merged commit 28affcb into google:master Dec 9, 2022
@MaicolAntali
Copy link
Contributor Author

9 also allows private but we build with Java 8.

Precisely, Java 9 has introduced that the SafeVarargs may be used only with private without final

but we build with Java 8

That's why I closed the PR #2275 and open this one :)

@MaicolAntali MaicolAntali deleted the remove-final-private-methods branch December 9, 2022 16:52
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Jan 20, 2023
@MaicolAntali @tibor-universe
Remove the final keyword from private method (google#2276)
d9a9e1b 
(cherry picked from commit 28affcb)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaicolAntali @eamonnmcmanus