Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Print clang-format output #181

Closed
kjin opened this issue Jun 26, 2018 · 0 comments
Closed

Print clang-format output #181

kjin opened this issue Jun 26, 2018 · 0 comments
Assignees

Comments

@kjin
Copy link
Contributor

kjin commented Jun 26, 2018

In #60:

A fix for this should be landed shortly (#62); all it does is add an error message if linting succeeds and formatting fails. I'm planning to add parsing clang-format XML output as a follow-up (PRs from your end would be more than welcome too). That being said, it's best to run gts fix to fix format issues anyway; I believe clang-format output is not necessarily meant to be human-interpretable.

When clang-format fails, all we do is print that there were formatting issues. gts fix fixes those issues, but it would still be nice to show the lines of code that need to be addressed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant