Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

gts check can fail with no output #60

Closed
kjin opened this issue Oct 13, 2017 · 2 comments
Closed

gts check can fail with no output #60

kjin opened this issue Oct 13, 2017 · 2 comments
Assignees
@kjin

Comments

@kjin
Copy link
Contributor

kjin commented Oct 13, 2017

No description provided.

@kjin kjin self-assigned this Oct 13, 2017
@KamranAsif
Copy link
Contributor

This is blocking me as well. Any updates on this?

@kjin
Copy link
Contributor Author

kjin commented Oct 17, 2017

A fix for this should be landed shortly (#62); all it does is add an error message if linting succeeds and formatting fails. I'm planning to add parsing clang-format XML output as a follow-up (PRs from your end would be more than welcome too). That being said, it's best to run gts fix to fix format issues anyway; I believe clang-format output is not necessarily meant to be human-interpretable.

@ofrobots ofrobots mentioned this issue Oct 19, 2017
Merged
@kjin kjin closed this as completed in d8789a4 Oct 19, 2017
@kjin kjin mentioned this issue Dec 6, 2017
Closed
@kjin kjin mentioned this issue Jun 26, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kjin kjin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kjin @KamranAsif