Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

Don't leave semicolon behind after consuming Æ #269

Merged
merged 1 commit into from
Dec 16, 2014

Conversation

rgrove
Copy link
Contributor

@rgrove rgrove commented Oct 28, 2014

Looks like someone snuck in another character reference with the same problem that was fixed in #249.

Related: rgrove/sanitize#119

Looks like someone snuck in another character reference with the same problem
that was fixed in google#249.
@dfguo
Copy link

dfguo commented Dec 16, 2014

+1 on this issue

1 similar comment
@syjstc
Copy link

syjstc commented Dec 16, 2014

+1 on this issue

nostrademons added a commit that referenced this pull request Dec 16, 2014
Don't leave semicolon behind after consuming `Æ`
@nostrademons nostrademons merged commit d6b952b into google:master Dec 16, 2014
@nostrademons
Copy link
Contributor

Oh wups, forgot to merge this. I'll pull the patch in to trunk so that it's fixed at HEAD; I am still somewhat curious as to why this caused it, as switching to Ragel was supposed to ensure that it always matches longest-match-first rather than first-match-first. If that's not the case there may be other regressions if any other entities are changed, and it may be worth writing a testcase to catch them.

@rgrove
Copy link
Contributor Author

rgrove commented Dec 16, 2014

@nostrademons: I think the cause this time was that AElig; wasn't even in the list of entities, but AElig was. I double-checked when I sent the patch and didn't find any other no-semicolon entities without a semicolon companion, so hopefully this shouldn't crop up again unless new no-semicolon entities are added.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants