openfhe: emit dense elements into a serialized binary file #1501
Conversation
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_731899276
branch
from
28b2cd8 to
83e50c1
Compare
To help with #1232 PiperOrigin-RevId: 731899276
copybara-service
bot
force-pushed
the
test_731899276
branch
from
83e50c1 to
7518910
Compare
| const std::string &weightsFile); | ||
|
|
||
| struct Weights { | ||
| std::map<std::string, std::vector<float>> floats; |
There was a problem hiding this comment.
Could you add some comments about the meaning of these fields? At first glance I'd guess the key is an SSA value name, but it takes a bit of searching to confirm. And the values are always dense elements attr values, but is a non-1D shape supported? (I think not, or else the shape would be lost in the archive and I don't see any code to reshape)
| #include <vector> | ||
|
|
||
| #include "include/cereal/archives/portable_binary.hpp" // from @cereal | ||
| #include "include/cereal/cereal.hpp" // from @cereal |
There was a problem hiding this comment.
This implies that the frontend, if it would like to use this flag for an openfhe backend, requires an include and shared lib for cereal when JIT-compiling, yes? Maybe file an issue for that, though it seems low priority for the moment.
There was a problem hiding this comment.
Is it possible to add an e2e openfhe test that runs this program? Otherwise the export/import logic is not tested in this PR, just the codegen for the interface.
openfhe: emit dense elements into a serialized binary file
To help with #1232