Mute Audio Default Setting #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaehwa-Noh
reviewed
Oct 1, 2024
|
In the currently used version of CameraX, you can now start a recording muted with |
Co-authored-by: Jaehwa Noh <shwoghk14@gmail.com>
temcguir
reviewed
Oct 8, 2024
feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt
Outdated
Show resolved
Hide resolved
feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsUiState.kt
Show resolved
Hide resolved
* remove .idea files * implement FakePermissionChecker for test
temcguir
reviewed
Oct 11, 2024
feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
Kimblebee
force-pushed
the
kim/feature/mute_audio_setting
branch
from
2f1d4de to
8a0569d
Compare
Jaehwa-Noh
reviewed
Nov 2, 2024
feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsUiState.kt
Outdated
Show resolved
Hide resolved
feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsUiState.kt
Outdated
Show resolved
Hide resolved
* files changed were also hit with the ktlinter
temcguir
reviewed
Dec 10, 2024
| constraintsRepository: ConstraintsRepository | ||
| ) : ViewModel() { | ||
| private var grantedPermissions = mutableSetOf<String>() |
There was a problem hiding this comment.
You should make this a MutableStateFlow<Set<String>> so that it can be combined into the below flow. Otherwise you have a race between this being set and the settings/constraints being updated.
# Conflicts: # core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraXCameraUseCase.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsScreen.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsUiState.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/SettingsViewModel.kt # feature/settings/src/main/java/com/google/jetpackcamera/settings/ui/SettingsComponents.kt # feature/settings/src/main/res/values/strings.xml # settings.gradle.kts
yasith
approved these changes
Jan 16, 2025
Kimblebee
force-pushed
the
kim/feature/mute_audio_setting
branch
from
9ca2dbc to
4fe4239
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent setting to start video recordings muted or with audio.
notable changes:
The permission to record audio is used as a constraint for the Mute Audio setting -- It will be disabled if the permission is not granted
Same process of adding a new setting...