Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improved external storage handling for external intent Image Capture #157 #307

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kazifahimislam
Copy link

@kazifahimislam kazifahimislam commented Feb 2, 2025

Add new permissions (READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO)

Issue:

The camera preview was not displaying properly due to incorrect PreviewView binding and lifecycle handling.

Fix:

Ensured PreviewView is correctly attached to the camera lifecycle.
Fixed the SurfaceProvider setup to prevent preview initialization failures.

Copy link

google-cla bot commented Feb 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

# Conflicts:
#	app/src/main/java/com/google/jetpackcamera/ui/JcaApp.kt
@kazifahimislam kazifahimislam changed the title Implement camera preview modes and UI state management in MainActivity Improved external storage handling for external intent Image Capture #157 Feb 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant