Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Setup liveness and readiness k8 probes #1418

Merged
merged 13 commits into from
Jan 6, 2020
Merged

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin requested a review from a team as a code owner December 20, 2019 15:48
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #1418 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   66.49%   66.31%   -0.18%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
- Hits         2677     2670       -7     
- Misses        958      962       +4     
- Partials      391      394       +3
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-4.29%) ⬇️
impl/sql/directory/storage.go 67.66% <0%> (-1.51%) ⬇️
core/sequencer/server.go 72.96% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214c0cf...058a40b. Read the comment docs.

@gdbelvin gdbelvin force-pushed the certmanager branch 4 times, most recently from 8dc13f4 to 7372cbd Compare January 2, 2020 17:12
@gdbelvin gdbelvin requested review from pav-kv and RJPercival January 2, 2020 19:41
Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits.

@gdbelvin gdbelvin force-pushed the certmanager branch 2 times, most recently from 040cb10 to d9570de Compare January 3, 2020 18:12
@gdbelvin gdbelvin merged commit 926eef1 into google:master Jan 6, 2020
@gdbelvin gdbelvin deleted the certmanager branch January 6, 2020 14:11
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants