This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Less flakey codecov #1421
Merged
Less flakey codecov #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 66.39% 66.31% -0.08%
==========================================
Files 54 54
Lines 4026 4026
==========================================
- Hits 2673 2670 -3
- Misses 960 962 +2
- Partials 393 394 +1
Continue to review full report at Codecov.
|
NatalieDoduc
approved these changes
Jan 14, 2020
| @@ -1,3 +1,14 @@ | |||
| ignore: | |||
| - "**/*.pb.go" # ignore generated protos | |||
| - "**/*.pb.gw.go" # ignore generated protos | |||
| coverage: | |||
| range: 60..80 | |||
There was a problem hiding this comment.
why an upper bound of 80? or am I misreading this config line?
There was a problem hiding this comment.
An upper bound of 80 means that code coverage above 80% will be marked as green.
This can be adjusted as the code coverage for the project grows over time.
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jan 15, 2020
* master: Less flakey codecov (google#1421) Cleanup old docker images (google#1430)
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage seems to bounce around a bit.
Allow it do bounce around by 1% without going red.