This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
GO111MODULE install directions #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current install instructions fall back to non-module mode non-module mode and result in incorrect dependencies. Fixes google#1390
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
- Coverage 66.56% 66.31% -0.25%
==========================================
Files 54 54
Lines 4026 4026
==========================================
- Hits 2680 2670 -10
- Misses 957 962 +5
- Partials 389 394 +5
Continue to review full report at Codecov.
|
RJPercival
reviewed
Feb 11, 2020
| @@ -33,7 +33,7 @@ development. | |||
|
|
|||
| ### Setup | |||
| 1. Install [Go 1.13](https://golang.org/doc/install). | |||
| 2. `go get github.com/google/keytransparency/cmd/keytransparency-client ` | |||
| 2. `GO111MODULE=on go get github.com/google/keytransparency/cmd/keytransparency-client` | |||
There was a problem hiding this comment.
If the user has installed Go 1.13, as specified in step 1, then this shouldn't be necessary should it? Nonetheless, it won't hurt.
RJPercival
approved these changes
Feb 11, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current install instructions fall back to non-module mode non-module
mode and result in incorrect dependencies.
Fixes #1390