Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Fix credential encryption #1479

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix credential encryption #1479

merged 1 commit into from
Feb 28, 2020

Conversation

gdbelvin
Copy link
Contributor

#1478 Messed this up by using a different file name than the original.

@gdbelvin gdbelvin requested a review from a team as a code owner February 28, 2020 10:33
@gdbelvin gdbelvin requested a review from RJPercival February 28, 2020 10:33
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1479 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
+ Coverage   67.83%   68.28%   +0.44%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
+ Hits         2731     2749      +18     
+ Misses        893      879      -14     
+ Partials      402      398       -4     
Impacted Files Coverage Δ
core/sequencer/server.go 73.61% <0.00%> (+0.65%) ⬆️
impl/sql/directory/storage.go 69.17% <0.00%> (+1.50%) ⬆️
core/keyserver/revisions.go 64.62% <0.00%> (+2.04%) ⬆️
core/sequencer/trillian_client.go 61.42% <0.00%> (+2.85%) ⬆️
core/sequencer/election/tracker.go 80.45% <0.00%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28fc8fd...202fc1c. Read the comment docs.

@gdbelvin gdbelvin requested review from NatalieDoduc and removed request for RJPercival February 28, 2020 10:43
Copy link

@NatalieDoduc NatalieDoduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please see some minor comments and questions below.

@gdbelvin gdbelvin merged commit c870922 into google:master Feb 28, 2020
@gdbelvin gdbelvin mentioned this pull request Feb 28, 2020
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants