Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add constraint for onnxruntime for the python package #801

Closed
reyammer opened this issue Nov 19, 2024 · 0 comments · Fixed by #802
Closed

Add constraint for onnxruntime for the python package #801

reyammer opened this issue Nov 19, 2024 · 0 comments · Fixed by #802
Assignees
@reyammer
Labels
python Pull requests that update Python package

Comments

@reyammer
Copy link
Collaborator

uv add onnxruntime currently fails on MacOS, which leads to the new magika package having problems as well.

For now, the suggestion from the uv folks is to add a version constraint for the onnxruntime version.

Context: astral-sh/uv#9228, astral-sh/uv#5182
@reyammer reyammer added the python Pull requests that update Python package label Nov 19, 2024
@reyammer reyammer self-assigned this Nov 19, 2024
@reyammer reyammer mentioned this issue Nov 19, 2024
Open
reyammer added a commit that referenced this issue Nov 20, 2024
@reyammer
python: constraint onnxruntime version to fix uv/macos problems
e28fc46 
`uv add onnxruntime` on MacOS currently fails as it resolves to 1.20.0,
even if that can't be used on MacOS. This, in turns, make `uv add
magika` fails as well.

Temporary fix is to help uv resolving to a proper version of
onnxruntime.

Close #801.
@reyammer reyammer mentioned this issue Nov 20, 2024
Merged
@reyammer reyammer mentioned this issue Nov 21, 2024
Closed
reyammer added a commit that referenced this issue Jan 23, 2025
@reyammer
python: relax constraint on onnxruntime
787301b 
With a past version of uv, `uv add onnxruntime` would fail. To address
that, we overly constrained the allowed onnxruntime version (#801).

More recent versions of uv have now fixed this
(astral-sh/uv#9827), so we remove the
constraint.

Fixes #835.
This was referenced Jan 23, 2025
Merged
Closed
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@reyammer reyammer

Labels
python Pull requests that update Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

python: constraint onnxruntime version to fix uv/macos problems google/magika
1 participant
@reyammer