Accept hypothetical Protobuf Editions files. #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should successfully generate code for these files. However, they do not have the correct semantics yet. `protoc` does not translate equivalent features supported in proto2 and proto3 into previous `FieldOptions` fields, and we must adjust the semantics according to what are specified in `FeatureSet` messages.
It will not accept actual Protobuf Editions files by restricting the supported edition to `LEGACY`. This restriction will be lifted once support for edition 2023 is complete.
blackgnezdo
approved these changes
Sep 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will not yet accept actual Protobuf Editions files by restricting the supported edition to
LEGACY. This restriction will be lifted once support for edition 2023 is complete with the following changes: https://github.com/chungyc/proto-lens/pull/6, https://github.com/chungyc/proto-lens/pull/7, https://github.com/chungyc/proto-lens/pull/8For issue #468.