Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Always escape values in comments as per specification #217

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Always escape values in comments as per specification #217

merged 2 commits into from
Dec 15, 2022

Conversation

kostyay
Copy link
Contributor

@kostyay kostyay commented Dec 15, 2022

Fixes #216

sjs994
sjs994 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@sjs994 sjs994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@sjs994 sjs994 merged commit 0579a4a into google:master Dec 15, 2022
@kostyay kostyay deleted the AlwaysEscapeValues branch December 15, 2022 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjs994 sjs994 sjs994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go: Incorrect specification implementation causes traceparent not to work properly
2 participants
@kostyay @sjs994