Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a [reusable] workflow for building wheels #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a [reusable] workflow for building wheels #42

wants to merge 3 commits into from
+91 −0

Conversation

peytondmurray
Copy link

This PR adds a workflow for building wheels. The workflow is triggered when

  1. A PR is made; PRs which break wheel builds will fail
  2. A release is made; if a release is made, the wheels are built and then uploaded to PyPI automatically. This requires trusted publishing to be set up in the repository. Please feel free to reach out if you need help with this, I'm happy to help set this up!
  3. Whenever the workflow is manually triggered, in which case it will also upload to PyPI automatically.

@peytondmurray peytondmurray marked this pull request as ready for review October 11, 2024 13:34
@peytondmurray
Copy link
Author

@aktech Would appreciate your input, particularly on the part that triggers the reusable workflow.

aktech
aktech approved these changes Oct 11, 2024
View reviewed changes
Copy link

@aktech aktech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than some minor nitpicks.

Also, I am guessing the extra files like bazel-* and wheel is committed accidentally.

@peytondmurray
Copy link
Author

peytondmurray commented Oct 12, 2024 •
edited
Loading

Also, I am guessing the extra files like bazel-* and wheel is committed accidentally.

Ugh, yes, these are added to a .gitignore in #40. I've removed these files here in this PR now.

@aktech aktech mentioned this pull request Oct 13, 2024
Draft
agriyakhetarpal
agriyakhetarpal suggested changes Oct 14, 2024
View reviewed changes
Copy link

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I stumbled across this PR via the same issue as the one linked in the code comment here, and I thought it would be nice to suggest a few improvements that I was able to notice. I had a chat with @peytondmurray beforehand so that this doesn't become an unsolicited review :D

agriyakhetarpal
agriyakhetarpal approved these changes Oct 14, 2024
View reviewed changes
Copy link

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side and I'm happy I was able to help somewhat!

@peytondmurray peytondmurray mentioned this pull request Oct 17, 2024
Merged
4 tasks
@peytondmurray
Copy link
Author

@hassler-google Is there anything else we need to do here? If not, could you please approve the workflow, then merge?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aktech aktech aktech approved these changes

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

@hassler-google hassler-google hassler-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peytondmurray @aktech @agriyakhetarpal @hassler-google