Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

all: remove unused dependencies #228

Merged
merged 1 commit into from
Dec 11, 2019
Merged

all: remove unused dependencies #228

merged 1 commit into from
Dec 11, 2019

Conversation

Clivern
Copy link
Contributor

@Clivern Clivern commented Dec 9, 2019

Removed https://github.com/fatih/color and https://github.com/mattn/go-colorable since they are not used anymore inside wire. even https://github.com/fatih/color got archived and not maintained anymore.

@go-cloud-bot
Copy link

go-cloud-bot bot commented Dec 9, 2019

Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Cannot accept contribution until Google CLA is signed. label Dec 9, 2019
@Clivern
Copy link
Contributor Author

Clivern commented Dec 9, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Google CLA has been signed! and removed cla: no Cannot accept contribution until Google CLA is signed. labels Dec 9, 2019
@Clivern Clivern changed the title Remove unused dependencies all: remove unused dependencies Dec 9, 2019
Copy link
Collaborator

@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zombiezen zombiezen merged commit 578b29e into google:master Dec 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants