-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: run wire with -mod=mod #353
Conversation
hi @eliben. Can you review this PR, please? |
hello @eliben, are you there? |
We're quite busy right now and working to figure out who the right person to review this would be. Please respect that this is an open source project that's offered to the community for free and in good will. Thanks for the understanding |
Thank you for your response, I understand what you mean. This is my first time contributing to this project, so just wanted to get some attention from the team for the review. Again, thank you very much. I will wait patiently for a response. Have a nice day! |
Hello @vangent. sorry to bother you, but can you help me review this PR? |
It seems this error happens after running
These are indirect dependencies. https://go.dev/issue/27664 seems relevant. Apparently the removal of these dependencies is intentional. Therefore this does seem like a simple fix to unblock "go generate" ... so LGTM. It's still unclear to me why this is not an issue when running the "wire" binary directly. |
hello @eliben, can you merge and release this PR please? |
The folks I've CCd on this issue in a previous comment all volunteered to maintain wire and are able to merge PRs. |
Hey @eliben, I think I only have triage rights, not write access, so I can't merge PRs. |
Hello, this PR is 1 year old. Do you consider making a release for it? |
FUCK Google google/wire#353 google/wire#364 (comment) This reverts commit c7b1290. Signed-off-by: black-desk <me@black-desk.cn>
This reverts commit f5e937d.
fixed the issue when using wire with Go module.
Close: #299, #342