yapf will fail on Python >= 3.13 because lib2to3 was removed #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lib2to3` has been removed from the standard library in Python 3.13. Document the incompatibility and the need for: * google#1258
|
This isn't true, lib2to3 is no longer used by YAPF since #1067 . The project does still need to move off even the forked version though because it's not feasible to patch _ylib2to3 with new Python language features. @ python --version; python -m yapf --diff get-pip.py
Python 3.14.0a1
--- get-pip.py (original)
+++ get-pip.py (reformatted)
@@ -28,11 +28,11 @@
message_parts = [
"This script does not work on Python {}.{}.".format(*this_python),
"The minimum supported Python version is {}.{}.".format(*min_version),
- "Please use https://bootstrap.pypa.io/pip/{}.{}/get-pip.py instead.".format(*this_python),
+ "Please use https://bootstrap.pypa.io/pip/{}.{}/get-pip.py instead.".
+ format(*this_python),
]
print("ERROR: " + " ".join(message_parts))
sys.exit(1)
-
import os.path
import pkgutil
@@ -28835,6 +28835,5 @@
a4%nWWo~3|axZmqY;0*_GcR>?X>2cdVQF+OaCuNm1qJ{B006H6uL0$R000pt8vp<R
"""
-
if __name__ == "__main__":
main() |
|
Awesome. Thanks much for your work on this. |
cclauss
commented
Feb 8, 2025
| python-version: ["3.8", "3.11", "3.12"] # no particular need for 3.9 or 3.10 | ||
| # Python >= 3.13 will fail with `ModuleNotFoundError: No module named 'lib2to3'` | ||
| # See: google/yapf#1258 | ||
| python-version: ["3.8", "3.11", "3.12", "3.13"] # no particular need for 3.9 or 3.10 |
There was a problem hiding this comment.
It still might be useful to add Py313 to the testing.
There was a problem hiding this comment.
Can probably drop 3.11 and 3.12 from the list. There's some special cases with 3.8 left in implementation code but 3.13 functionally tests everything >3.10 or greater.
There's also no special 3.9 code.
cclauss
added a commit
to cclauss/yapf
that referenced
this pull request
Feb 9, 2025
```
matrix:
# There is version-specific code for Python 3.8 but none for 3.9.
# Python 3.13 functionally tests everything for Python >= v3.10.
python-version: ["3.8", "3.13"]
```
Python 3.8 is now [end-of-life](https://devguide.python.org/versions) but still worth testing.
As discussed at google#1265 (comment)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib2to3has been removed from the standard library in Python 3.13.Document the incompatibility and the need for: