Deny more Clippy lints (#65)

Closes #50
google · Oct 15, 2022 · 22c66b6 · 22c66b6
1 parent 7a1617a
commit 22c66b6
Show file tree

Hide file tree

Showing 2 changed files with 146 additions and 60 deletions.
diff --git a/src/byteorder.rs b/src/byteorder.rs
@@ -511,8 +511,13 @@ mod tests {
     macro_rules! impl_traits {
         ($name:ident, $native:ident, $bytes:expr, $sign:ident) => {
             impl Native for $native {
+                // For some types, `0 as _` is required (for example, when
+                // `$native` is a floating-point type; `0` is an integer), but
+                // for other types, it's a trivial cast. In all cases, Clippy
+                // thinks it's dangerous.
+                #[allow(trivial_numeric_casts, clippy::as_conversions)]
                 const ZERO: $native = 0 as _;
-                const MAX_VALUE: $native = ::core::$native::MAX;
+                const MAX_VALUE: $native = $native::MAX;
 
                 fn rand() -> $native {
                     rand::random()
@@ -586,9 +591,9 @@ mod tests {
     }
 
     #[cfg(target_endian = "big")]
-    type NonNativeEndian = byteorder::LittleEndian;
+    type NonNativeEndian = LittleEndian;
     #[cfg(target_endian = "little")]
-    type NonNativeEndian = byteorder::BigEndian;
+    type NonNativeEndian = BigEndian;
 
     #[test]
     fn test_zero() {