Skip to content

Rename AsBytes to IntoBytes #695

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
2 tasks done
Tracked by #251
joshlf opened this issue Dec 8, 2023 · 0 comments · Fixed by #700
Closed
2 tasks done
Tracked by #251

Rename AsBytes to IntoBytes #695

joshlf opened this issue Dec 8, 2023 · 0 comments · Fixed by #700
Labels
compatibility-breaking Changes that are (likely to be) breaking

Comments

@joshlf
Copy link
Member

joshlf commented Dec 8, 2023 •
edited
Loading

Progress

  • Decide between ToBytes and IntoBytes
    • Decided to go with IntoBytes so that FromBytes/IntoBytes is symmetrical with stdlib's From/Into
  • Implementation
    • In progress in #700

Description

Now that AsBytes permits UnsafeCells as part of #251, it can be implemented for types which support value-only transmutation (ie, for which fn as_bytes(&self) -> &[u8] where Self: NoCell is not available because Self: !NoCell). Given this change, a more appropriate name for the trait would be IntoBytes. This also brings our pair of FromBytes/IntoBytes into line with the existing pattern of From/Into.
@joshlf joshlf added the compatibility-breaking Changes that are (likely to be) breaking label Dec 8, 2023
This was referenced Dec 8, 2023
Open
Closed
joshlf added a commit that referenced this issue Dec 8, 2023
@joshlf
Rename AsBytes to ToBytes
fbf02b9 
TODO

Closes #695
@joshlf joshlf mentioned this issue Dec 8, 2023
Merged
joshlf added a commit that referenced this issue Dec 8, 2023
@joshlf
Rename AsBytes to ToBytes
a7e81ef 
TODO

Closes #695
joshlf added a commit that referenced this issue Dec 8, 2023
@joshlf
Rename AsBytes to ToBytes
b895345 
TODO

Closes #695
joshlf added a commit that referenced this issue Dec 8, 2023
@joshlf
Rename AsBytes to ToBytes
6ccd880 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `ToBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `ToBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
joshlf added a commit that referenced this issue Dec 11, 2023
@joshlf
Rename AsBytes to IntoBytes
98330a0 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `IntoBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `IntoBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
@joshlf joshlf changed the title Rename AsBytes to ToBytes Rename AsBytes to IntoBytes Dec 11, 2023
joshlf added a commit that referenced this issue Dec 11, 2023
@joshlf
Rename AsBytes to IntoBytes
37f544f 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `IntoBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `IntoBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
joshlf added a commit that referenced this issue Dec 11, 2023
@joshlf
Rename AsBytes to IntoBytes
0586963 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `IntoBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `IntoBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
joshlf added a commit that referenced this issue Dec 11, 2023
@joshlf
Rename AsBytes to IntoBytes
d6e93da 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `IntoBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `IntoBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2023
@joshlf
Rename AsBytes to IntoBytes (#700)
24b5a9b 
Previously, `T: AsBytes` indicated that `&T -> &[u8]` was a valid
transformation. As of #682, `T: AsBytes` only indicates that `T -> [u8]`
is a valid transformation. This slightly changes the meaning of
`AsBytes` and makes `IntoBytes` a more appropriate name since it only
permits value rather than reference transmutations. This also brings the
pair of `FromBytes` and `IntoBytes` in line with the standard library
`From` and `Into` traits from a naming perspective.

Closes #695
joshlf added a commit that referenced this issue Feb 23, 2024
@joshlf
[derive] Support deriving deprecated AsBytes
742a8b5 
This makes the transition from `AsBytes` to `IntoBytes` (its new name)
easier.

Makes progress on #695
@joshlf joshlf mentioned this issue Feb 23, 2024
Merged
joshlf added a commit that referenced this issue Feb 23, 2024
@joshlf
[derive] Support deriving deprecated AsBytes
046483f 
This makes the transition from `AsBytes` to `IntoBytes` (its new name)
easier.

Makes progress on #695
joshlf added a commit that referenced this issue Feb 23, 2024
@joshlf
[derive] Support deriving deprecated AsBytes
04854d6 
This makes the transition from `AsBytes` to `IntoBytes` (its new name)
easier.

Makes progress on #695
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
@joshlf
[derive] Support deriving deprecated AsBytes (#938)
47bc243 
This makes the transition from `AsBytes` to `IntoBytes` (its new name)
easier.

Makes progress on #695
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
compatibility-breaking Changes that are (likely to be) breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename AsBytes to IntoBytes google/zerocopy
1 participant
@joshlf