Don't assume primitive type alignments #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
primitive-alignments
branch
4 times, most recently
from
3a580a9 to
4483f9f
Compare
|
Hey @djkoloski , mind reviewing this one? (Looks like I can't add you as a reviewer, at least not yet - I might be able to once you've commented on this thread) |
joshlf
changed the title
|
Yep, feel free to add me as a reviewer. 🙂 |
djkoloski
previously approved these changes
Nov 3, 2022
|
Do you think it'd be worth using |
|
Eh, |
joshlf
force-pushed
the
primitive-alignments
branch
from
4483f9f to
077a639
Compare
|
Good call; done! I was able to use the |
Previously, we used the `u16` and `u64` types in a number of tests, relying on them having the alignments 2 and 8 respectively. While those types have those alignments on many platforms, those are not guaranteed to be their alignments on all platforms. In this commit, we replace most of these uses with types of the same size but guaranteed alignment. In a few places, we have to leave the uses as-is, but this isn't a big deal since our tests run in CI on platforms where the alignments are actually the values we're relying upon. Closes #116
joshlf
force-pushed
the
primitive-alignments
branch
from
077a639 to
f424f1f
Compare
djkoloski
approved these changes
Nov 5, 2022
joshlf
added a commit
that referenced
this pull request
Aug 3, 2023
Previously, we used the `u16` and `u64` types in a number of tests, relying on them having the alignments 2 and 8 respectively. While those types have those alignments on many platforms, those are not guaranteed to be their alignments on all platforms. In this commit, we replace most of these uses with types of the same size but guaranteed alignment. In a few places, we have to leave the uses as-is, but this isn't a big deal since our tests run in CI on platforms where the alignments are actually the values we're relying upon. Closes #116
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the
u16andu64types in a number of tests,relying on them having the alignments 2 and 8 respectively. While those
types have those alignments on many platforms, those are not guaranteed
to be their alignments on all platforms. In this commit, we replace
most of these uses with types of the same size but guaranteed alignment.
In a few places, we have to leave the uses as-is, but this isn't a big
deal since our tests run in CI on platforms where the alignments are
actually the values we're relying upon.
Closes #116