[derive] IntoBytes on unions requires --cfg #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
I've asked for advice on the build failures on URLO. |
joshlf
force-pushed
the
union-into-bytes-derive-cfg
branch
4 times, most recently
from
b458728 to
ad4766f
Compare
jswrenn
approved these changes
Oct 3, 2024
joshlf
force-pushed
the
union-into-bytes-derive-cfg
branch
2 times, most recently
from
31f847b to
089d6d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 16 16
Lines 5994 5994
=======================================
Hits 5239 5239
Misses 755 755 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshlf
force-pushed
the
union-into-bytes-derive-cfg
branch
from
089d6d7 to
2fe7d1c
Compare
joshlf
force-pushed
the
union-into-bytes-derive-cfg
branch
2 times, most recently
from
36484da to
4bcf323
Compare
Makes progress on #1792
joshlf
force-pushed
the
union-into-bytes-derive-cfg
branch
from
4bcf323 to
09e3beb
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #1792