Enforce Src: FromBytes in try_transmute_mut!
#2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
69ad562 to
2bf3099
Compare
|
(Have a killer headache tonight; I'll finish this up first thing tomorrow.) |
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
2bf3099 to
4fdd646
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2229 +/- ##
==========================================
+ Coverage 87.42% 87.46% +0.04%
==========================================
Files 16 16
Lines 6115 6136 +21
==========================================
+ Hits 5346 5367 +21
Misses 769 769 ☔ View full report in Codecov by Sentry. |
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
4fdd646 to
cc95f58
Compare
joshlf
requested changes
Jan 27, 2025
src/macros.rs
Outdated
| @@ -577,7 +577,7 @@ macro_rules! try_transmute_ref { | |||
| /// ```ignore | |||
| /// fn try_transmute_mut<Src, Dst>(src: &mut Src) -> Result<&mut Dst, ValidityError<&mut Src, Dst>> | |||
| /// where | |||
| /// Src: IntoBytes, | |||
| /// Src: FromByte + IntoBytes, | |||
There was a problem hiding this comment.
Suggested change
| /// Src: FromByte + IntoBytes, | |
| /// Src: FromBytes + IntoBytes, |
src/macros.rs
Outdated
Comment on lines
891
to
894
| let array_of_bools = &mut [false, true, false, true, false, true, false, true]; | ||
| let array_of_arrays = &mut [[0u8, 1], [0, 1], [0, 1], [0, 1]]; | ||
| let x: Result<&mut [[u8; 2]; 4], _> = try_transmute_mut!(array_of_bools); | ||
| assert_eq!(x, Ok(array_of_arrays)); |
There was a problem hiding this comment.
Can we keep this test and use u8 instead of bool?
Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped. Makes progress on #2226
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
cc95f58 to
018a552
Compare
joshlf
approved these changes
Feb 4, 2025
6 tasks
joshlf
pushed a commit
that referenced
this pull request
Feb 14, 2025
Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped. Makes progress on #2226 gherrit-pr-id: I425e7d5103cb3b2a9e7107bf9df0743dca2e08cb
|
Backporting in #2343 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ryFromBytes::try_mut*` (#2343) * Enforce `Src: FromBytes` in `try_transmute_mut!` (#2229) Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped. Makes progress on #2226 gherrit-pr-id: I425e7d5103cb3b2a9e7107bf9df0743dca2e08cb * Add `Self: IntoBytes` bound to `TryFromBytes::try_mut*` Consider that `MaybeUninit<u8>` is `TryFromBytes`. If a `&mut [u8]` is cast into a `&mut MaybeUninit<u8>`, then uninit bytes are written, the shadowed `&mut [u8]`'s referent will no longer be valid. Makes progress towards #2226 and #1866. gherrit-pr-id: Ib233c4d0643e0690c53a37a08d9845e5fe43249c --------- Co-authored-by: Jack Wrenn <jswrenn@amazon.com> Co-authored-by: Jack Wrenn <jack@wrenn.fyi>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped.
Makes progress on #2226