Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add async generator logic to ProcessPromise #984

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

mxmvshnvsk
Copy link
Contributor

@mxmvshnvsk mxmvshnvsk commented Dec 14, 2024

Fixes #965

Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

src/core.ts Show resolved Hide resolved
@antongolub antongolub added the ossln24 OSS Library Night 2024 label Dec 15, 2024
@mxmvshnvsk mxmvshnvsk force-pushed the async-generator branch 7 times, most recently from f50d90b to 1d65ba2 Compare December 15, 2024 20:43
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Thanks for your efforts.

@antongolub antongolub merged commit 3841cbe into google:main Dec 15, 2024
21 checks passed
@mxmvshnvsk mxmvshnvsk deleted the async-generator branch December 15, 2024 21:04
antongolub added a commit to antongolub/zx that referenced this pull request Dec 17, 2024
@antongolub antongolub mentioned this pull request Dec 17, 2024
2 tasks
antongolub added a commit to antongolub/zx that referenced this pull request Dec 17, 2024
antongolub added a commit that referenced this pull request Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ossln24 OSS Library Night 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: make ProcessPromise iterable via async for
3 participants