Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Regenerate compute_gapic.yaml #91

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Regenerate compute_gapic.yaml #91

merged 1 commit into from
Sep 5, 2018

Conversation

andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Sep 5, 2018 •
edited
Loading

We need to regenerate the gapic config for compute in order to refresh the library itself, because the gapic config defines new resource types and methods that were introduced in the compute Discovery doc.

@andreamlin andreamlin requested a review from yihanzhen September 5, 2018 00:01
@andreamlin andreamlin mentioned this pull request Sep 5, 2018
Merged
@andreamlin
Copy link
Contributor Author

PTAL
The regenerated compute library passes tests googleapis/google-cloud-java#3642

yihanzhen
yihanzhen approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@yihanzhen yihanzhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 3ca9d5d into googleapis:master Sep 5, 2018
@andreamlin andreamlin deleted the compute_gapic_config branch September 5, 2018 18:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yihanzhen yihanzhen yihanzhen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreamlin @yihanzhen