feat: Generate enum strings for Compute #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note that we could remove one piece of config by generating one type per FileDescriptor, and using the name of the FileDescriptor as a prefix with a hard-coded suffix. Compute only has Testing: this is basically tested by running it against the Compute API and checking that the result is "identical" (in semantic diff terms) to the current code. |
amanda-tarafa
approved these changes
Jan 16, 2025
|
|
||
| public static CompilationUnitSyntax MaybeGenerate(SourceFileContext ctx, string ns, IEnumerable<FileDescriptor> packageFileDescriptors) | ||
| { | ||
| // TODO: Add an option in the service config for this... although |
There was a problem hiding this comment.
nit: seems incomplete... although I'll probably be happy with what comes after the although :)
| namespace Google.Api.Generator.Generation; | ||
|
|
||
| /// <summary> | ||
| /// Generates (to stdout) a static class (with nested static classes) to provide |
There was a problem hiding this comment.
Suggested change
| /// Generates (to stdout) a static class (with nested static classes) to provide | |
| /// Generates a static class (with nested static classes) to provide |
| /// <summary> | ||
| /// Generates (to stdout) a static class (with nested static classes) to provide | ||
| /// string constants for the wire representations of enum values. This is only used | ||
| /// for DIREGAPIC APIs. |
There was a problem hiding this comment.
Suggested change
| /// for DIREGAPIC APIs. | |
| /// for DIREGAPIC APIs which is just the Compute API. |
| if (Descriptor is not null) | ||
| { | ||
| Utils.Logging.LogWarning("Typ of {name} is {fullname}", Descriptor.FullName, ProtoTyp.Of(Descriptor).FullName); | ||
| //throw new Exception($"Typ of {Descriptor.FullName} is {ProtoTyp.Of(Descriptor).FullName}"); |
amanda-tarafa
approved these changes
Jan 16, 2025
This moves code from google-cloud-dotnet to the generator, removing the post-processing. We can probably adopt this as-is for the moment (given that this is only for DIREGAPIC, and only Compute uses DIREGAPIC) but we should really have configuration within the service config publish settings to turn this feature on (and potentially configure the filename; that'll be easier to tell if we end up with more examples).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves code from google-cloud-dotnet to the generator, removing the post-processing.
We can probably adopt this as-is for the moment (given that this is only for DIREGAPIC, and only Compute uses DIREGAPIC) but we should really have configuration within the service config publish settings to turn this feature on (and potentially configure the filename; that'll be easier to tell if we end up with more examples).