This repository was archived by the owner on Sep 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: implemented watchdog as BackgroundResource #838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates watchdog to BackgroundResource, Also, watchdog unschedules itself explicitly when shutdown. closes googleapis#828
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
============================================
- Coverage 78.73% 78.61% -0.12%
- Complexity 1151 1161 +10
============================================
Files 202 202
Lines 5107 5140 +33
Branches 407 413 +6
============================================
+ Hits 4021 4041 +20
- Misses 913 925 +12
- Partials 173 174 +1
Continue to review full report at Codecov.
|
igorbernstein2
suggested changes
Jan 6, 2020
igorbernstein2
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for fixing this
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates watchdog to BackgroundResource, Also, watchdog unschedules itself explicitly when shutdown.
closes #828