Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

feat: implemented watchdog as BackgroundResource #838

Merged
merged 4 commits into from
Jan 7, 2020

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Jan 3, 2020

This change updates watchdog to BackgroundResource, Also, watchdog unschedules itself explicitly when shutdown.

closes #828

This change updates watchdog to BackgroundResource, Also, watchdog unschedules itself explicitly when shutdown.

closes googleapis#828
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #838 into master will decrease coverage by 0.11%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #838      +/-   ##
============================================
- Coverage     78.73%   78.61%   -0.12%     
- Complexity     1151     1161      +10     
============================================
  Files           202      202              
  Lines          5107     5140      +33     
  Branches        407      413       +6     
============================================
+ Hits           4021     4041      +20     
- Misses          913      925      +12     
- Partials        173      174       +1
Impacted Files Coverage Δ Complexity Δ
...gle/api/gax/rpc/InstantiatingWatchdogProvider.java 90.9% <100%> (-0.76%) 16 <1> (+1)
.../com/google/api/gax/rpc/FixedWatchdogProvider.java 100% <100%> (ø) 10 <1> (+1) ⬆️
...ain/java/com/google/api/gax/rpc/ClientContext.java 80.88% <50%> (-0.94%) 9 <0> (+1)
...src/main/java/com/google/api/gax/rpc/Watchdog.java 80.5% <85.71%> (+0.91%) 11 <5> (+5) ⬆️
...main/java/com/google/api/gax/grpc/ChannelPool.java 45.9% <0%> (-3.04%) 13% <0%> (+2%)
...api/gax/grpc/InstantiatingGrpcChannelProvider.java 79.89% <0%> (-0.22%) 35% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbefe87...76f3d5f. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for fixing this

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix WatchDog leak
3 participants