Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: MediaIoBaseDownload range header off-by-one #1595

Merged
merged 2 commits into from
Nov 11, 2021
Merged

fix: MediaIoBaseDownload range header off-by-one #1595

merged 2 commits into from
Nov 11, 2021

Conversation

jvtm
Copy link
Contributor

@jvtm jvtm commented Nov 8, 2021 •
edited by parthea
Loading

Issue: It looks like Range header end value was constructed by adding chunk size to
current position. This leads into the request being one byte longer, and also
the received response body is one byte longer than anticipated.

Fix: adjust the end to be one byte earlier.

For example with chunksize=1024 and current position being 0, the range header
should be set to bytes=0-1023.

See: https://httpwg.org/specs/rfc7233.html#rule.ranges-specifier

Fixes #1593

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1593 🦕

@jvtm jvtm requested a review from a team as a code owner November 8, 2021 20:43
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 8, 2021
@jvtm
fix: MediaIoBaseDownload range header off-by-one
d9777dc 
Issue: It looks like Range header end value was constructed by adding chunk size to
current position. This leads into the request being one byte longer, and also
the received response body is one byte longer than anticipated.

Fix: adjust the end to be one byte earlier.

For example with `chunksize=1024` and current position being 0, the range header
should be set to `bytes=0-1023`.

See: https://httpwg.org/specs/rfc7233.html#rule.ranges-specifier

Resolves: googleapis#1593
@jvtm jvtm force-pushed the fix-mediaiobasedownload-range-header branch from 4262b62 to d9777dc Compare November 9, 2021 09:34
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 9, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2021
@parthea
Copy link
Contributor

parthea commented Nov 11, 2021

Thanks for the fix @jvtm !

@parthea parthea added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4b73b2e into googleapis:main Nov 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Nov 11, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 16, 2021
@release-please
chore: release 2.31.0 (#1604)
3b53d79 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.31.0](https://github.com/googleapis/google-api-python-client/compare/v2.30.0...v2.31.0) (2021-11-16)


### Features

* **bigtableadmin:** update the api be7ffcc ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **chromemanagement:** update the api 59c9799 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **cloudasset:** update the api 60f5758 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **cloudfunctions:** update the api c517033 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **contactcenterinsights:** update the api 9ac9faa ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **containeranalysis:** update the api 618985b ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **datapipelines:** update the api a39bb0f ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **datastore:** update the api 5050adb ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **dialogflow:** update the api fd46c12 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **documentai:** update the api 3ba3182 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **drive:** update the api b1840b0 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **file:** update the api b13a249 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **gkehub:** update the api 37cce48 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **healthcare:** update the api 8d1f955 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **metastore:** update the api 9c90df7 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **monitoring:** update the api bf890b6 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **mybusinessbusinessinformation:** update the api 90e206c ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **paymentsresellersubscription:** update the api c879654 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **recaptchaenterprise:** update the api ff95700 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **recommender:** update the api d85fe38 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **securitycenter:** update the api 35a6d4e ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **speech:** update the api 13f1bcb ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **sqladmin:** update the api 770bc14 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **tpu:** update the api ea30e3a ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))
* **vmmigration:** update the api 80e2090 ([815c1ac](https://github.com/googleapis/google-api-python-client/commit/815c1ac7e3f7c7ea6df920645adb8cba84b05c22))


### Bug Fixes

* MediaIoBaseDownload range header off-by-one ([#1595](https://github.com/googleapis/google-api-python-client/issues/1595)) ([4b73b2e](https://github.com/googleapis/google-api-python-client/commit/4b73b2e9d53e63404c8800f2a2b3f1ee86680815))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MediaIoBaseDownload next_chunk() Range header off-by-one
3 participants
@jvtm @parthea @yoshi-kokoro