Skip to content

mTLS support for batch and custom http object #2442

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jay0lee
Copy link
Contributor

@jay0lee jay0lee commented Jul 17, 2024

First stab at addressing #2440.

  • mTLS logic in build_from_document such as choosing the mtlsRootUrl should be executed even if we pass a custom http object in.
  • add an is_mtls bool attribute to Resource so we can make quick decisions about the state of mTLS later.
  • ensure our batch URI is using the mTLS host when is_mtls == True

feedback welcome.

@jay0lee jay0lee requested a review from a team as a code owner July 17, 2024 11:53
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants