Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: per google style, logger is lower case #529

Merged
merged 3 commits into from
Dec 31, 2020
Merged

fix: per google style, logger is lower case #529

merged 3 commits into from
Dec 31, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 21, 2020

@kolea2 Also per Google style, most text should be in present tense.

@elharo elharo requested a review from kolea2 December 21, 2020 13:52
@elharo elharo requested a review from a team as a code owner December 21, 2020 13:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #529 (c7565c7) into master (ec74870) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #529   +/-   ##
=========================================
  Coverage     80.06%   80.06%           
  Complexity      421      421           
=========================================
  Files            28       28           
  Lines          1966     1966           
  Branches        209      209           
=========================================
  Hits           1574     1574           
  Misses          283      283           
  Partials        109      109           
Impacted Files Coverage Δ Complexity Δ
...om/google/auth/appengine/AppEngineCredentials.java 71.69% <100.00%> (ø) 16.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec74870...c7565c7. Read the comment docs.

Copy link

@yoshi-code-bot yoshi-code-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • appengine/java/com/google/auth/appengine/AppEngineCredentials.java
    • lines 87-90

Comment on lines 74 to 76
logger.warning("You are attempting to "
+ "fetch Application Default Credentials from com.google.auth.appengine.AppEngineCredentials."
+ " This method will not return a com.google.auth.appengine.AppEngineCredentials instance.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.warning("You are attempting to "
+ "fetch Application Default Credentials from com.google.auth.appengine.AppEngineCredentials."
+ " This method will not return a com.google.auth.appengine.AppEngineCredentials instance.");
logger.warning(
"You are attempting to "
+ "fetch Application Default Credentials from com.google.auth.appengine.AppEngineCredentials."
+ " This method will not return a com.google.auth.appengine.AppEngineCredentials instance.");

@elharo elharo merged commit ecfc6a2 into master Dec 31, 2020
@elharo elharo deleted the ae branch December 31, 2020 11:39
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 26, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.23.0](https://github.com/googleapis/google-auth-library-java/compare/v0.22.2...v0.23.0) (2021-01-26)


### ⚠ BREAKING CHANGES

* privatize deprecated constructor (#473)

### Features

* allow custom lifespan for impersonated creds ([#515](https://github.com/googleapis/google-auth-library-java/issues/515)) ([0707ed4](https://github.com/googleapis/google-auth-library-java/commit/0707ed4bbb40fb775f196004ee30f8c695fe662b))
* allow custom scopes for compute engine creds ([#514](https://github.com/googleapis/google-auth-library-java/issues/514)) ([edc8d6e](https://github.com/googleapis/google-auth-library-java/commit/edc8d6e0e7ca2c6749d026ba42854a09c4879fd6))
* allow set lifetime for service account creds ([#516](https://github.com/googleapis/google-auth-library-java/issues/516)) ([427f2d5](https://github.com/googleapis/google-auth-library-java/commit/427f2d5610f0e8184a21b24531d2549a68c0b546))
* promote IdToken and JWT features ([#538](https://github.com/googleapis/google-auth-library-java/issues/538)) ([b514fe0](https://github.com/googleapis/google-auth-library-java/commit/b514fe0cebe5a294e0cf97b7b5349e6a523dc7b2))


### Bug Fixes

* per google style, logger is lower case ([#529](https://github.com/googleapis/google-auth-library-java/issues/529)) ([ecfc6a2](https://github.com/googleapis/google-auth-library-java/commit/ecfc6a2ea6060e06629b5d422b23b842b917f55e))
* privatize deprecated constructor ([#473](https://github.com/googleapis/google-auth-library-java/issues/473)) ([5804ff0](https://github.com/googleapis/google-auth-library-java/commit/5804ff03a531268831ac797ab262638a3119c14f))
* remove deprecated methods ([#537](https://github.com/googleapis/google-auth-library-java/issues/537)) ([427963e](https://github.com/googleapis/google-auth-library-java/commit/427963e04702d8b73eca5ed555539b11bbe97342))
* replace non-precondition use of Preconditions ([#539](https://github.com/googleapis/google-auth-library-java/issues/539)) ([f2ab4f1](https://github.com/googleapis/google-auth-library-java/commit/f2ab4f14262d54de0fde85494cfd92cf01a30cbe))
* switch to GSON ([#531](https://github.com/googleapis/google-auth-library-java/issues/531)) ([1b98d5c](https://github.com/googleapis/google-auth-library-java/commit/1b98d5c86fc5e56187c977e7f43c39bb62483d40))
* use default timeout if given 0 for ImpersonatedCredentials ([#527](https://github.com/googleapis/google-auth-library-java/issues/527)) ([ec74870](https://github.com/googleapis/google-auth-library-java/commit/ec74870c372a33d4157b45bb5d59ad7464fb2238))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.84 ([#422](https://github.com/googleapis/google-auth-library-java/issues/422)) ([b262c45](https://github.com/googleapis/google-auth-library-java/commit/b262c4587b058e6837429ee05f1b6a63620ee598))
* update dependency com.google.guava:guava to v30.1-android ([#522](https://github.com/googleapis/google-auth-library-java/issues/522)) ([4090d1c](https://github.com/googleapis/google-auth-library-java/commit/4090d1cb50041bceb1cd975d1a9249a412df936f))


### Documentation

* fix wording in jwtWithClaims Javadoc ([#536](https://github.com/googleapis/google-auth-library-java/issues/536)) ([af21727](https://github.com/googleapis/google-auth-library-java/commit/af21727815263fb5ffc07ede953cf042fac3ac2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants