Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a warning for 3 legged OAuth credentials #199

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 18, 2018

Fixes #198

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2018
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmatsuo tmatsuo merged commit 8057ced into googleapis:master Jul 19, 2018
@lbergelson
Copy link

@tmatsuo How can an application silence this warning? Our application is a command line application that most users use directly with their credentials and this message is confusing to them.

@dwsupplee
Copy link
Contributor

@lbergelson a follow up PR was issued which introduces an environment variable. Setting SUPPRESS_GCLOUD_CREDS_WARNING to true should suppress.

@lbergelson
Copy link

@dwsupplee Oh, that's perfect, thank you. I hadn't seen that.

@dwsupplee
Copy link
Contributor

You're welcome!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants