Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

GCE_METADATA_ROOT should be called GCE_METADATA_HOST to be aligned with other client libraries #339

Closed
ensonic opened this issue May 6, 2019 · 1 comment · Fixed by #433
Closed

GCE_METADATA_ROOT should be called GCE_METADATA_HOST to be aligned with other client libraries #339

ensonic opened this issue May 6, 2019 · 1 comment · Fixed by #433
Assignees
@michaelawyu
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@ensonic
Copy link

ensonic commented May 6, 2019

file https://github.com/googleapis/google-auth-library-python/blob/master/google/auth/environment_vars.py
contains GCE_METADATA_ROOT added in:
b33b802

Client libs for other languages call it GCE_METADATA_HOST:
go: https://github.com/googleapis/google-cloud-go/blob/master/compute/metadata/metadata.go
java: https://github.com/googleapis/google-auth-library-java/blob/master/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
...

Maybe consider supporting both names for a transition?
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels May 7, 2019
@busunkim96 busunkim96 added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Aug 20, 2019
@michaelawyu michaelawyu self-assigned this Jan 23, 2020
michaelawyu pushed a commit to michaelawyu/google-auth-library-python that referenced this issue Jan 23, 2020
fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA…
8be748a 
…_HOST

* keeps consistent naming across auth packages of all languages.

    The package will now check GCE_METADATA_HOST (the new name) first; if not present, it falls back to GCE_METADATA_ROOT (the old name), then the default value.

closes [googleapis#339](googleapis#339).
@michaelawyu michaelawyu mentioned this issue Jan 23, 2020
Merged
@busunkim96
Copy link
Contributor

I'd like to go through and check in the other languages before taking the change:

  • NodeJS
  • Ruby
  • PHP
  • C#
  • C++ (? unsure if they have a separate auth library)

gcf-merge-on-green bot pushed a commit that referenced this issue Jun 4, 2020
fix: replace environment variable GCE_METADATA_ROOT with GCE_METADATA…
8ffb4d3 
…_HOST (#433)

…_HOST

* keeps consistent naming across auth packages of all languages.

    The package will now check GCE_METADATA_HOST (the new name) first; if not present, it falls back to GCE_METADATA_ROOT (the old name), then the default value.

closes [#339](#339).
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 4, 2020
@release-please
chore: release 1.16.1 (#522)
16df8a3 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.16.1](https://github.com/googleapis/google-auth-library-python/compare/v1.16.0...v1.16.1) (2020-06-04)


### Bug Fixes

* fix impersonated cred exception doc ([#521](https://github.com/googleapis/google-auth-library-python/issues/521)) ([9d5a9a9](https://github.com/googleapis/google-auth-library-python/commit/9d5a9a9884fecbd698a602d2a9fd9bec6b987de7))
* replace environment variable GCE_METADATA_ROOT with GCE_METADATA_HOST ([#433](https://github.com/googleapis/google-auth-library-python/issues/433)) ([8ffb4d3](https://github.com/googleapis/google-auth-library-python/commit/8ffb4d3e832607869026444e5a071c5f3e225fd2)), closes [#339](https://github.com/googleapis/google-auth-library-python/issues/339)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@ijrsvt ijrsvt mentioned this issue Dec 8, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@michaelawyu michaelawyu

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
4 participants
@ensonic @busunkim96 @michaelawyu @yoshi-automation