Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JWT decoding depends upon deprecated function #773

Closed
tpdownes opened this issue Jun 10, 2021 · 0 comments · Fixed by #846
Closed

JWT decoding depends upon deprecated function #773

tpdownes opened this issue Jun 10, 2021 · 0 comments · Fixed by #846
Assignees
@busunkim96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tpdownes
Copy link

tpdownes commented Jun 10, 2021 •
edited
Loading

Environment details

  • OS: Debian 11 (bullseye)
  • Python version: 3.9.2
  • pip version: 20.3.4
  • google-auth version: 1.30

Steps to reproduce

Decode a JWT token from Google Cloud Identity-Aware Proxy

Error

The following deprecation warnings are issues from the cryptography library:

/usr/local/lib/python3.9/dist-packages/google/auth/crypt/es256.py:56: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead
/usr/local/lib/python3.9/dist-packages/google/auth/crypt/es256.py:57: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead

The changes necessary seem self evident. The function in question exists in Python 3.2+ and therefore falls within the currently stated supported versions (3.5+).
@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Jun 11, 2021
@busunkim96 busunkim96 self-assigned this Jun 11, 2021
@busunkim96 busunkim96 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: cleanup An internal cleanup or hygiene concern. labels Jun 11, 2021
@busunkim96 busunkim96 mentioned this issue Aug 20, 2021
Merged
tseaver added a commit that referenced this issue Aug 23, 2021
@tseaver
fix: use 'int.to_bytes' rather than deprecated crypto wrapper
2166bb4 
Follow-on to #773, #846.
@tseaver tseaver mentioned this issue Aug 23, 2021
Merged
tseaver added a commit that referenced this issue Aug 23, 2021
@tseaver
fix: use 'int.to_bytes' rather than deprecated crypto wrapper (#848)
b79b554 
Follow-on to #773, #846.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use int.from_bytes googleapis/google-auth-library-python
2 participants
@tpdownes @busunkim96