Add service_account.Credentials.with_claims #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
reviewed
Mar 23, 2017
google/auth/jwt.py
Outdated
| @@ -426,13 +426,15 @@ def with_claims(self, issuer=None, subject=None, audience=None, | |||
| Returns: | |||
| google.auth.jwt.Credentials: A new credentials instance. | |||
| """ | |||
| new_additional_claims = self._additional_claims.copy() | |||
google/auth/jwt.py
Outdated
| @@ -426,13 +426,15 @@ def with_claims(self, issuer=None, subject=None, audience=None, | |||
| Returns: | |||
| google.auth.jwt.Credentials: A new credentials instance. | |||
| """ | |||
| new_additional_claims = self._additional_claims.copy() | |||
| new_additional_claims.update(additional_claims or {}) | |||
| @@ -246,6 +246,29 @@ def with_subject(self, subject): | |||
| subject=subject, | |||
| additional_claims=self._additional_claims.copy()) | |||
|
|
|||
| def with_claims(self, additional_claims): | |||
|
LGTM I suppose. It seems you want to eat the teeny cost of |
The cost of that vs. the cost of copy/deepcopy is insignificant. I'm going to update this to use deepcopy, but I'm finishing something else up first. Thanks for the review! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #129.